fix rate limits #57
Merged
fix rate limits #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatterchats
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently rate limits are (once again) applied globally since the client IP address (which is used as the rate limit bucket) doesn't seem to be correctly set by the forwarded headers middleware.
tests indicate this is because it processes right to left, whereas Fly places the eventual client IP on the left.
so basically:
<client-ip>,<proxy-1>,<proxy-2>etc, and the app would only process<proxy-2>and never<client-ip>essentially enforcing a global rate limit per proxy regionthis PR ensures that proxies are correctly processed, which in turn should fix the rate limit