Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make raw endpoints future-proof #42

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Make raw endpoints future-proof #42

merged 3 commits into from
Apr 4, 2024

Conversation

dealloc
Copy link
Member

@dealloc dealloc commented Apr 4, 2024

As described in #41 makes the /raw endpoints return the received information byte-per-byte.
It does this by storing the raw binary payload received as Memory<byte> and then passing that as a binary stream back to the user.

This bypasses the entire serialization step, and allows sending whatever ArrowHead provides, even if they change their schema at some point

dealloc added 2 commits April 4, 2024 02:06
Changes how the raw endpoints provide their data.
Rather than providing serialized versions of the endpoints we send the raw binary payloads

fix #41
@dealloc dealloc added the feature request This issue requests a feature that doesn't exist (yet) label Apr 4, 2024
@dealloc dealloc added this to the V1 milestone Apr 4, 2024
@dealloc dealloc requested a review from a team April 4, 2024 00:09
@dealloc dealloc linked an issue Apr 4, 2024 that may be closed by this pull request
nullability is guarded by `_syncState`
Copy link
Contributor

@chatterchats chatterchats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically just removing data validation on the raw streams, and instead returning the raw byte for byte data instead, sounds good to me! Build passed CI, no complaints here.

@chatterchats chatterchats merged commit 326128c into master Apr 4, 2024
1 check passed
@chatterchats chatterchats deleted the fix/41 branch April 4, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request This issue requests a feature that doesn't exist (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: raw payloads should be 'raw'
2 participants