Make raw endpoints future-proof #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes how the raw endpoints provide their data. Rather than providing serialized versions of the endpoints we send the raw binary payloads fix #41
dealloc
added
the
feature request
nullability is guarded by `_syncState`
chatterchats
reviewed
Apr 4, 2024
chatterchats
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #41 makes the
/rawendpoints return the received information byte-per-byte.It does this by storing the raw binary payload received as
Memory<byte>and then passing that as a binary stream back to the user.This bypasses the entire serialization step, and allows sending whatever ArrowHead provides, even if they change their schema at some point