Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: assignments #27

Closed
wants to merge 3 commits into from
Closed

Conversation

milogert
Copy link

@milogert milogert commented Mar 21, 2024

Found at https://api.live.prod.thehelldiversgame.com/api/v2/Assignment/War/801

How I ran into this, I have no idea.

This is a ROUGH change, that I'm happy to get feedback on. I basically copied patterns that already existed.

Additionally I added some Nix-related things. I have found developing Elixir with Nix to be a great experience. I copied the files from another project so there might be extraneous stuff in there.

TODO

  • The schema stuff for Swagger, completely not done.
  • Tests
  • Elixir versions in Nix

Found at https://api.live.prod.thehelldiversgame.com/api/v2/Assignment/War/801

How I ran into this, I have no idea.

This is a _ROUGH_ change, that I'm happy to get feedback on. I basically
copied patterns that already existed.
@milogert milogert marked this pull request as ready for review March 21, 2024 04:17
@dealloc
Copy link
Member

dealloc commented Mar 21, 2024

hi @milogert great to have your contribution here!
I'll be checking this out ASAP when I have the chance, the one thing I'm not too keen on is the addition of Nix as I have no experience with this so I'm not entirely comfortable reviewing Nix related code :)

@milogert
Copy link
Author

Thanks for looking at this!

As for the Nix stuff, it should be viewed like the .vscode directory in repositories. Basically this code I added is just a dev-related change, so it can be ignored be ignored by people who don't have Nix installed. The big exception is if you bump the Elixir version then the version in the shell.nix file should be bumped as well.

All that being said, I'd be happy to maintain that part of the code or whatever! If you ever get any bugs related to it (or bump the Elixir version) feel free to assign me to it and I'd love to take a look. Chances are someone just ran into the bug before me

@dealloc
Copy link
Member

dealloc commented Mar 22, 2024

I'm going to keep this open until #28 gives a little more clarification on the direction we're taking with this project

@dealloc
Copy link
Member

dealloc commented Mar 26, 2024

hi @milogert, while I really appreciate the contribution I'm afraid I'm going to have to close this in favour of #30 as discussed in #28

I hope to see more contributions from you going forward :)

@dealloc dealloc closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants