Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add routing for space station endpoints added in #120 #124

Merged
merged 2 commits into from
Nov 15, 2024
Merged

add routing for space station endpoints added in #120 #124

merged 2 commits into from
Nov 15, 2024

Conversation

dealloc
Copy link
Member

@dealloc dealloc commented Nov 15, 2024

we were a little too fast in #120, mapping support was present but no real API route for clients to fetch the data

@dealloc dealloc added bug Something isn't working mapping This issue or it's solution is related to how information is mapped labels Nov 15, 2024
@dealloc dealloc added this to the V1 milestone Nov 15, 2024
@dealloc dealloc requested review from lambstream, chatterchats and a team November 15, 2024 09:23
@dealloc dealloc self-assigned this Nov 15, 2024
lambstream
lambstream previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@lambstream lambstream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops seems like I missed that in the last PR

chatterchats
chatterchats approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@chatterchats chatterchats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like nothing should melt

@dealloc dealloc merged commit 857d396 into master Nov 15, 2024
3 checks passed
@dealloc dealloc deleted the feature/space-station branch November 15, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chatterchats chatterchats chatterchats approved these changes

@lambstream lambstream lambstream approved these changes

Assignees

@dealloc dealloc

Labels
bug Something isn't working mapping This issue or it's solution is related to how information is mapped
Projects
None yet
Milestone
V1
Development

Successfully merging this pull request may close these issues.
3 participants
@dealloc @lambstream @chatterchats