-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance #114
Merged
Merged
Maintenance #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Microsoft.CodeAnalysis, System.Text.Json, and various Microsoft.Extensions package versions to their latest releases.
Implements validation for X-Super-Client and X-Super-Contact headers in the RateLimitMiddleware. Includes a configuration setting to enable or disable header validation. see #94
dealloc
added
bug
Something isn't working
documentation
Improvements or additions to documentation
feature request
This issue requests a feature that doesn't exist (yet)
mapping
This issue or it's solution is related to how information is mapped
dependencies
Pull requests that update a dependency file
labels
Nov 10, 2024
lambstream
requested changes
Nov 10, 2024
lambstream
approved these changes
Nov 10, 2024
chatterchats
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
feature request
This issue requests a feature that doesn't exist (yet)
mapping
This issue or it's solution is related to how information is mapped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty big PR that addresses some of the pending issues:
ISourceGenerator
toIIncrementalGenerator
which speeds up the source generation from the JSON files to C# filesX-Super-Client
header required #94) also updates relevant documentation to disable on self hostI'm hoping that updating the json files also addresses #105 but that remains to be seen