Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: make X-Super-Client header required #94

Open
dealloc opened this issue Apr 29, 2024 · 3 comments
Open

[FEATURE]: make X-Super-Client header required #94

dealloc opened this issue Apr 29, 2024 · 3 comments
Assignees
Labels
blocked issue needs more information or input to be picked up documentation Improvements or additions to documentation feature request This issue requests a feature that doesn't exist (yet)
Milestone

Comments

@dealloc
Copy link
Member

dealloc commented Apr 29, 2024

What problem does it solve

It requires clients using the hosted version of the API to send along a X-Super-Client header that identifies their application, and optionally a X-Super-Contact header with developer contact info.

This allows us to identify applications and contact developers when implementing breaking changes or if their apps are causing problems.

What is the solution

Make the header required (after a grace period)

Existing alternatives

none

Added value

This allows us to identify applications and contact developers when implementing breaking changes or if their apps are causing problems.

Additional notes

Provide a way to disable this check for self-hosted containers

@dealloc dealloc added documentation Improvements or additions to documentation feature request This issue requests a feature that doesn't exist (yet) blocked issue needs more information or input to be picked up labels Apr 29, 2024
@dealloc dealloc added this to the V1 milestone Apr 29, 2024
@dealloc dealloc self-assigned this Apr 29, 2024
@chatterchats
Copy link
Contributor

What kind of grace period are we looking at for mandatory implementation?

@dealloc
Copy link
Member Author

dealloc commented Apr 30, 2024

mostly depends on how fast I can identify most developers and communicate the changes

We left the Elixir version up and running for approximately 30-50 days

@chatterchats
Copy link
Contributor

chatterchats commented Apr 30, 2024

HellCom Support PR #11
Helldivers Companion (Organization) PR #8 - Implemented
Helldivers Training Manual PR #13 - Implemented
Helldivers.Widget Issue #1 - Implemented in c3947584
Heckdivers Issue #1 PR #2 - Implemented
Dive Stats PR #1 - Implemented
Helldivers Help PR #1 - Implemented
Bruhbot PR #6 - Implemented
Helldivers History - Implemented in 3ea5a78
Helldivers Companion (Devpoole) PR #1 - Implemented

That's every repo that I could find on github that uses helldivers2.dev or the fly.dev link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked issue needs more information or input to be picked up documentation Improvements or additions to documentation feature request This issue requests a feature that doesn't exist (yet)
Projects
None yet
Development

No branches or pull requests

2 participants