feat(txs): Add a Priority Fee Cap #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasPennie
approved these changes
Oct 1, 2024
| @@ -546,24 +547,32 @@ export class RpcClient { | |||
| * @param {TransactionInstruction[]} instructions - The transaction instructions | |||
| * @param {Signer[]} signers - The transaction's signers. The first signer should be the fee payer | |||
| * @param {AddressLookupTableAccount[]} lookupTables - The lookup tables to be included in a versioned transaction. Defaults to `[]` | |||
| * @param {Signer} feePayer - Optional fee payer separate from the signers | |||
| * @param {SerializeConfig} serializeOptions - Options for transaction serialization. This applies only to legacy transactions. Defaults to `{ requireAllSignatures = true, verifySignatures: true }` | |||
| * @param {SmartTransactionOptions} options - Options for customizing the transaction, including an optional fee payer separate from the signers, a | |||
There was a problem hiding this comment.
nit: You don't need to define all options, instead you can JSDoc the options themselves
| @@ -370,4 +373,11 @@ export type PollTransactionOptions = { | |||
| timeout?: number; | |||
| // In milliseconds | |||
| interval?: number; | |||
| } | |||
|
|
|||
| export interface SmartTransactionOptions extends SendOptions { | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a priority fee cap for smart transactions. The idea is that the user should be able to cap priority fees at a specific number and use that instead of what is strictly returned by the Priority Fee API. This PR also reworks the send options for smart transactions to make it more intuitive