Feat/675 on chain ouis devaddrs #972
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryzettler
requested review from
bbalser,
jeffgrunewald,
macpie and
michaeldjeffrey
| @@ -0,0 +1,9 @@ | |||
| -- Migration here solely for testing purposes | |||
There was a problem hiding this comment.
Could we move all the tables for testing into a single migration file?
Or into the fixtures folder somehow so we don't have to wonder about dangling tables in prod that are unused?
There was a problem hiding this comment.
These tables should never be dangling as they are the exact tables that a postgres_sink_instance will be creating/managing. They just need to exist at runtime for the tests also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.