Skip to content

Conversation

@kurotych
Copy link
Member

@kurotych kurotych commented Sep 30, 2025

The name "latest_timestamp" misleads and don't reflect actual behavior.

Here you can see that we process only first timestamp (in an hour) not the latest one
https://github.com/helium/oracles/blob/fe810082cabfe04e966e323215939ccbd9e1bffb/mobile_verifier/src/heartbeats/mod.rs#L619C1-L625C6

@kurotych kurotych marked this pull request as ready for review September 30, 2025 11:20
Comment on lines +13 to +14
#[sqlx(rename = "first_timestamp")]
pub heartbeat_timestamp: DateTime<Utc>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're updating the name of the field and the column in the database, can they match?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're updating the name of the field and the column in the database, can they match?

From the perspective of the LastLocation struct, first_timestamp sounds a bit awkward to me, which is why I named it simply heartbeat_timestamp, as it belongs to the location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants