Rename latest_timestamp to first_timestamp in wifi_heartbeats table #1056
+17
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+13
to
+14
| #[sqlx(rename = "first_timestamp")] | ||
| pub heartbeat_timestamp: DateTime<Utc>, |
There was a problem hiding this comment.
If we're updating the name of the field and the column in the database, can they match?
There was a problem hiding this comment.
If we're updating the name of the field and the column in the database, can they match?
From the perspective of the LastLocation struct, first_timestamp sounds a bit awkward to me, which is why I named it simply heartbeat_timestamp, as it belongs to the location.
bbalser
approved these changes
Oct 6, 2025
michaeldjeffrey
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name "latest_timestamp" misleads and don't reflect actual behavior.
Here you can see that we process only first timestamp (in an hour) not the latest one
https://github.com/helium/oracles/blob/fe810082cabfe04e966e323215939ccbd9e1bffb/mobile_verifier/src/heartbeats/mod.rs#L619C1-L625C6