Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove source from map properly, symmetric to addition. #60

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

jjimenezshaw
Copy link

wms.Layer.onAdd is adding this._source to this._map, but is not removed symmetrically on onRemove.

The consequence is that the attribution is never removed if the layer is removed/managed using L.Control.Layers. If you change to different layers that use wms.Layer, the attributions are appended (never removed), even if you remove the layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant