Refactor #11
Open
Refactor #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assapir
reviewed
Jun 14, 2024
| @@ -12,4 +12,4 @@ version = "0.1.1" | |||
|
|
|||
| [dependencies] | |||
| chrono = { workspace = true } | |||
| once_cell = "1.19.0" | |||
| lazy_static = "1.4.0" | |||
There was a problem hiding this comment.
Not sure what the benefits are of using lazy_static vs. once_cell::lazy?
assapir
reviewed
Jun 14, 2024
| } | ||
|
|
||
| #[inline] | ||
| fn reminder(x: i32, y: i32) -> i32 { | ||
| x - y * (x as f32 / y as f32).floor() as i32 | ||
| x.rem_euclid(y) |
assapir
reviewed
Jun 14, 2024
| @@ -199,22 +203,16 @@ impl HebrewMonth { | |||
| /// let month = HebrewMonth::try_from_ym(HebrewMonth::AdarI as u8, 5763).unwrap(); | |||
| /// assert_eq!(month, HebrewMonth::AdarI); | |||
| pub fn try_from_ym(month: u8, year: u32) -> Result<HebrewMonth, HebrewDateErrors> { | |||
| // ??? Why not use assert, should be consistent | |||
There was a problem hiding this comment.
Good point. Maybe we should assert on it
assapir
approved these changes
Jun 14, 2024
Larmbs
commented
Jun 14, 2024
I hope all is well, yeah I'm not sure why you put floor in some places and not others. But integer division already accounts for that so it's a simple optimization. |
|
I was actually considering making my own Hebrew date calculator, but after seeing yours I thought it was best to help out. |
not to happy about this, but eventually better fitting result types will be made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.