Quell some SonarCloud code smells

hebcal · Dec 8, 2024 · 6345a25 · 6345a25
1 parent 4f08d8a
commit 6345a25
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/src/common.ts b/src/common.ts
@@ -376,7 +376,7 @@ export function shouldRenderBrief(ev: Event): boolean {
   const mask = ev.getFlags();
   if (mask & flags.HEBREW_DATE) {
     const hd = ev.getDate();
-    return hd.getDate() === 1 ? false : true;
+    return hd.getDate() !== 1;
   } else if (
     mask &
     (flags.DAILY_LEARNING | flags.DAF_YOMI | flags.YERUSHALMI_YOMI)

diff --git a/src/csv.ts b/src/csv.ts
@@ -90,7 +90,8 @@ export function eventToCsv(ev: Event, options: RestApiOptions): string {
     .replace(/"/g, "''")
     .replace(/\n/g, ' / ');
 
-  const showTimeAs = timed || mask & flags.CHAG ? 4 : 3;
+  const isChag = Boolean(mask & flags.CHAG);
+  const showTimeAs = timed || isChag ? 4 : 3;
   return `"${subj}",${date},${startTime},${endDate},${endTime},${allDay},"${memo}","${showTimeAs}","${loc}"`;
 }
 

diff --git a/src/fullcalendar.ts b/src/fullcalendar.ts
@@ -16,7 +16,8 @@ import {
 export function eventToFullCalendar(ev: Event, tzid: string, il: boolean): any {
   const classes = getEventCategories(ev);
   const mask = ev.getFlags();
-  if (classes[0] === 'holiday' && mask & flags.CHAG) {
+  const isChag = Boolean(mask & flags.CHAG);
+  if (isChag && classes[0] === 'holiday') {
     classes.push('yomtov');
   }
   const timedEv = ev as TimedEvent;

diff --git a/test/common.spec.js b/test/common.spec.js
@@ -1,4 +1,4 @@
-import {RestApiOptions,
+import {
   getDownloadFilename, getCalendarTitle, makeTorahMemoText, getEventCategories,
   getHolidayDescription,
   appendIsraelAndTracking, locationToPlainObj, shouldRenderBrief} from '../src/common';