Allow non-negative alarms

hebcal · Oct 21, 2021 · 2c3ec4a · 2c3ec4a
1 parent 09e8a4a
commit 2c3ec4a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hebcal/icalendar",
-  "version": "4.14.0",
+  "version": "4.14.1",
   "author": "Michael J. Radwin (https://github.com/mjradwin)",
   "keywords": [
     "ical",

diff --git a/src/icalendar.js b/src/icalendar.js
@@ -127,11 +127,11 @@ export class IcalEvent {
     if (ev.alarm) {
       this.alarm = ev.alarm;
     } else if (mask & flags.OMER_COUNT) {
-      this.alarm = '0DT3H30M0S'; // 8:30pm Omer alarm evening before
+      this.alarm = '-P0DT3H30M0S'; // 8:30pm Omer alarm evening before
     } else if (isUserEvent) {
-      this.alarm = '0DT12H0M0S'; // noon the day before
+      this.alarm = '-P0DT12H0M0S'; // noon the day before
     } else if (timed && ev.getDesc().startsWith('Candle lighting')) {
-      this.alarm = '0DT0H10M0S'; // ten minutes
+      this.alarm = '-P0DT0H10M0S'; // ten minutes
     }
 
     this.category = ev.category || CATEGORY[getEventCategories(ev)[0]];
@@ -199,7 +199,7 @@ export class IcalEvent {
           'BEGIN:VALARM',
           'ACTION:DISPLAY',
           'DESCRIPTION:This is an event reminder',
-          `TRIGGER:-P${this.alarm}`,
+          `TRIGGER:${this.alarm}`,
           'END:VALARM',
       );
     }