Split non-calendar code into modular files #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows' cmd doesn't expand globs, so I explicitly list every file instead
And record their sizes on build
This relies on downstream applications to decide how/which/whether to include polyfills, saving ~50KB. And remove polyfills entirely from size-demo
…single bundle. This makes tree shaking much better. This is a breaking change, but I can fix that by adding a forwarder.
Consuming applications will already install dependencies, so there is no point in bundling them. This probably also helps resolve conflicts/duplication, where an application may have ended up importing its installed copy of `HDate` as separate from the bundled `HDate`. - This reduces index.cjs from 470KB to 177KB - This fixes the size increase from the previous commit, which had included Babel polyfills in the ES bundle
This demo file was the same 404KB before
|
This is not quite ready yet (I'm still testing & fixing leyning), but can you please take a look and let me know what you think? |
This only has modest savings, because most of the code comes from this very function. This is not worth splitting; instead, we should redo the API first.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this isn't a breaking change.
This PR fixes most of #475: