New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Rollup config to TypeScript and simplify #476

Closed

SLaks wants to merge 4 commits into hebcal:main from SLaks:rollup

Contributor

SLaks commented Nov 1, 2024

I ended up not needing this (see https://github.com/SLaks/hebcal-es6/blob/modular/size-demo/rollup.config.ts), but I already wrote it, so here it is.

SLaks added 4 commits

October 31, 2024 20:13


          chore: Make npm build work on Windows

d3dfee8

Windows' cmd doesn't expand globs, so I explicitly list every file instead


          build: Install rollup-plugin-bundle-size to see sizes on build

076cd04


          build: Migrate rollup config to TypeScript

4ce4c8f


          build: Extract common plugins and output options to shared variables

9546f09

sonarqubecloud bot commented Nov 1, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Contributor Author

SLaks commented Nov 1, 2024 •

edited

Loading

It looks like it is impossible to import a JSON file and build against Node v22 and Node v20. https://stackoverflow.com/questions/78876691/syntaxerror-unexpected-identifier-assert-on-json-import-in-node-v22

Given that, should I:

Read the JSON using fs instead of import
Abandon TypeScript, but keep the rest of this PR
Drop this PR entirely
Drop support for Node <22 or Node 22

SLaks closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet