Use "bce" in suffix of hebcal.com URLs for events before common era

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hebcal/core",
-  "version": "3.17.1",
+  "version": "3.17.2",
   "author": "Michael J. Radwin (https://github.com/mjradwin)",
   "contributors": [
     "Eyal Schachter (https://github.com/Scimonster)",

src/holidays.js

@@ -55,7 +55,8 @@ export class HolidayEvent extends Event {
   }
   /** @return {string} */
   urlDateSuffix() {
-    return this.getDate().greg().getFullYear();
+    const year = this.getDate().greg().getFullYear();
+    return year < 0 ? -year + 'bce' : year;
   }
 }
 
@@ -103,7 +104,10 @@ export class AsaraBTevetEvent extends HolidayEvent {
   }
   /** @return {string} */
   urlDateSuffix() {
-    return this.getDate().greg().toISOString().substring(0, 10).replace(/-/g, '');
+    const isoDateTime = this.getDate().greg().toISOString();
+    const isoDate = isoDateTime.substring(0, isoDateTime.indexOf('T'));
+    const suffix = isoDate[0] === '-' ? 'bce' : '';
+    return isoDate.replace(/-/g, '') + suffix;
   }
 }
 

src/holidays.spec.js

@@ -395,6 +395,17 @@ test('asara-btevet-url', (t) => {
   t.deepEqual(urls, expected);
 });
 
+test('bce-url', (t) => {
+  const urls = HebrewCalendar.calendar({year: -776})
+      .filter((ev) => ev.getDesc() === 'Asara B\'Tevet' || ev.getDesc() === 'Yom Kippur')
+      .map((ev) => ev.url());
+  const expected = [
+    'https://www.hebcal.com/holidays/yom-kippur-776bce',
+    'https://www.hebcal.com/holidays/asara-btevet-0007761217bce',
+  ];
+  t.deepEqual(urls, expected);
+});
+
 test('getHolidaysForYear-ce', (t) => {
   const map = HebrewCalendar.getHolidaysForYear(5888);
   const rh = map.get('1 Tishrei 5888').map(eventDateDesc)[0];

src/sedra.js

@@ -515,9 +515,17 @@ export class ParshaEvent extends Event {
   }
   /** @return {string} */
   url() {
-    const dt = this.getDate().greg().toISOString().substring(0, 10).replace(/-/g, '');
+    const dt = this.urlDateSuffix();
     const url = 'https://www.hebcal.com/sedrot/' +
       this.basename().toLowerCase().replace(/'/g, '').replace(/ /g, '-') + '-' + dt;
     return this.il ? url + '?i=on' : url;
   }
+
+  /** @return {string} */
+  urlDateSuffix() {
+    const isoDateTime = this.getDate().greg().toISOString();
+    const isoDate = isoDateTime.substring(0, isoDateTime.indexOf('T'));
+    const suffix = isoDate[0] === '-' ? 'bce' : '';
+    return isoDate.replace(/-/g, '') + suffix;
+  }
 }

src/sedra.spec.js

@@ -132,3 +132,8 @@ test('complete-incomplete-types', (t) => {
     t.not(sedraIL.find(0), null);
   }
 });
+
+test('bce-url', (t) => {
+  const ev = new ParshaEvent(new HDate(new Date(-428, 8, 30)), ['Bereshit']);
+  t.is(ev.url(), 'https://www.hebcal.com/sedrot/bereshit-0004280930bce');
+});