Skip to content

Add workflow to identify RPB ZSS in ALMA RPB-60 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Aug 23, 2023

@acka47
Copy link
Contributor

acka47 commented Aug 24, 2023

This looks very good. The JSON can easily be imported in OpenRefine:

image

Apparently, the lobid-resources reconciliation service is down at the moment so I could not try out reconciliation.

Copy link
Contributor

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@acka47 acka47 requested a review from fsteeg August 31, 2023 12:52
build.sbt Outdated
@@ -17,7 +17,7 @@ libraryDependencies ++= Seq(
"org.metafacture" % "metafacture-flux" % "5.7.0-rc1",
"org.metafacture" % "metafacture-triples" % "5.7.0-rc1",
"org.metafacture" % "metafacture-formatting" % "5.7.0-rc1",
"org.metafacture" % "metafix" % "0.6.0-rc3",
"org.metafacture" % "metafix" % "0.6.0-SNAPSHOT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the build to fail.

@TobiasNx Did you need something specific in the SNAPSHOT, or was this just to make it work for you locally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, it was just to make it work locally. The new release should be good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'll revert to 0.6.0-rc3 for now, which is configured in the GitHub CI action.

@TobiasNx TobiasNx assigned fsteeg and unassigned TobiasNx Sep 1, 2023
@fsteeg
Copy link
Member

fsteeg commented Sep 1, 2023

Assigning @acka47, since you have been working on the reconciliation in OpenRefine. Now that the build passes you can merge this if that makes sense to you (not quite sure about the state of this since it's a draft).

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Sep 1, 2023
Copy link
Contributor Author

@TobiasNx TobiasNx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acka47 the fix does not exclude DE-36 anymore.

@TobiasNx TobiasNx marked this pull request as ready for review September 20, 2023 12:12
@TobiasNx
Copy link
Contributor Author

@fsteeg should I merge this, or do you do it?

@fsteeg
Copy link
Member

fsteeg commented Oct 19, 2023

I think this should contain some documentation about what this is (there is no issue linked and no description provided here), maybe in the README? In particular where the input file comes from and how we are using the output.

@acka47 acka47 assigned TobiasNx and unassigned acka47 Mar 24, 2025
@acka47
Copy link
Contributor

acka47 commented Mar 24, 2025

As discussed in today's meeting, please provide some context, @TobiasNx :

this should contain some documentation about what this is (there is no issue linked and no description provided here), maybe in the README? In particular where the input file comes from and how we are using the output.

@TobiasNx TobiasNx changed the title Add workflow to identify RPB ZSS in ALMA Add workflow to identify RPB ZSS in ALMA RPB-60 Apr 9, 2025
@TobiasNx
Copy link
Contributor Author

TobiasNx commented Apr 9, 2025

As discussed in today's meeting, please provide some context, @TobiasNx :

this should contain some documentation about what this is (there is no issue linked and no description provided here), maybe in the README? In particular where the input file comes from and how we are using the output.

  • This PR should provide with ("zss.json) the basis for the list of "Ausgewertete Zeitschriften" of RPB, which was part of "Allegro Register 7"

  • Input (conf/RPB-Export_HBZ_ZSS.txt) was not part of the initial allegro export by Mr. D. but was later provided by Mrs. C. https://jira.hbz-nrw.de/browse/RPB-60?focusedId=306309&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-306309

  • The output is generated via conf/rpb-7-ZSS-mapping.flux and conf/rpb-7-ZSS-mapping.fix keeping the id, the title, the holding library id and isil as well as a linked query to lobid to find the results. The fix was improved by the feedback of LBZ provided in RPB-60

  • The output (zss.json) should be uploaded to openRefine and as suggested by Mr. M not automatically matched but manually be checked by LBZ.

  • The result should be added to ALMA data as selection sign similar to NWBIB and create a dynamical list of the "Ausgewertete Zeitschrifte der RPB" similar to: https://nwbib.de/journals

  • I tried to upload the newly generated list to openRefine and reconcile the results against lobid-resources. It seems that the reconcile service of lobid resources is not working anymore. @fsteeg could you check that.

I will add additional content and links to the JIRA Ticket: https://jira.hbz-nrw.de/browse/RPB-60

@acka47 and @fsteeg is that what you needed as context?

@acka47
Copy link
Contributor

acka47 commented Apr 9, 2025

@acka47 and @fsteeg is that what you needed as context?

Yes, great. Thanks!

The result should be added to ALMA data as selection sign similar to NWBIB and create a dynamical list of the "Ausgewertete Zeitschrifte der RPB" similar to: https://nwbib.de/journals

I guess this would have to happen in ZDB wouldn't it?

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Apr 9, 2025

I can think of multiple ways to do that:
a) a "simple" mapping in lobid (would be not so good to maintain) but could be a start
b) add it to ALMA, not sure if that is possible
c) add it to ZDB, we could use lobid to reconcile the ZDB IDs and perhaps ZDB could batch update the matched records, lbz had to add and remove new and old signutares at zdb
d) add a new content type to strapi, similar to fremddaten

a, b and d would need a mapping for almaMmsId to the rpbIds of the journals
c would need a zdbId mapping to rpbId

The reconciliation could help with both.

@fsteeg
Copy link
Member

fsteeg commented Apr 10, 2025

It seems that the reconcile service of lobid resources is not working anymore. @fsteeg could you check that.

Now running again at https://test.lobid.org/resources/reconcile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants