Fix classification retrieval for updated Elasticsearch version #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative threshold interferes with small internal index too early
Default setting resulted in 588 missing classification entries. With Elasticsearch 5.6, this resulted in missing top-level entries, while previously the missing entries went unnoticed.
The classifications are only updated manually and require a restart
Counts are retrieved via aggregations, the lookups don't add any additional results, they only increase runtime and network traffic
dr0i
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.hbz-nrw.de/browse/RPB-266
The actual fix is in 48d0f35, this PR also adds some performance improvements related to the classification index.