Add skos:closeMatch, skos:altLabel, skos:scopeNote from Allegro #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acka47
requested changes
Jun 19, 2024
There was a problem hiding this comment.
Das sieht schonmal ganz gut aus. Der abgebrochene SkoHub Build zeigt aber, dass noch etwas zu tun ist: https://skohub.io/build/?id=17d230ff-3d55-42ba-8bd7-58c566ed05df
Konkret sind folgende Dinge anzupassen:
- Bei
skos:closeMatchsollte in Objekt-Position ein URI sein und kein String. - Die
skos:scopeNote-Strings sollten mit dem language tagdeversehen werden.
|
As we could use some automatic SHACL validation in this repo so that we could easily see violations in Pull Requests, I have opened #221 . You might go ahead implementing this in this PR to get immediate automatic feedback in this PR. |
|
Closing in favour of #225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RPB-80