Set up reconciliation service for subdomain usage #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows usage of relative links both in `reconcile` subdomain deployment as well as in lobid.org/gnd/reconcile/ deployment - Switch back to the `@desc` block for query and extend GET sample
fsteeg
force-pushed
the
reconcileSubdomain
branch
from
e7bb134 to
c94b7fa
Compare
To fix usage of redirecting URL (no trailing slash) in OpenRefine
|
I think I don't like that https://reconcile.lobid.org/ points to lobid.org/gnd while we also have other lobid-services (resources; organisations ...). But that is decided as it is already officially documented at https://reconcile.lobid.org/ ? |
|
No, https://reconcile.lobid.org/ is just for testing. It's the value configured in application.conf on the test system, that's why it appears on the page. I agree it's confusing and should be renamed e.g. to https://reconcile-gnd-test.lobid.org/ (in the GitLab issue though, where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic idea: we replace the internal
@routes.Reconcile.reconcile()route (/gnd/reconcile/) with the host name fromconf/application.conf(set tohttps://reconcile.lobid.orgfor testing). The web server proxies/to/gnd/reconcile/(as well as/gnd/->/gnd/for assets and view / preview links).