Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy to the setup.py 'install_required' #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nagasaki45
Copy link

The project relies on numpy, ins't it? import tgt fails without having numpy installed.

@hbuschme
Copy link
Owner

Thanks for pointing this out and submitting a pull request. You are right, numpy is required in order to use the functions in tgt.agreement.

As the core functionality of tgt does not require numpy, I'm wondering whether we should really add numpy as a dependency to the library – it is huge. We have to think through how we will proceed on this matter: add numpy as a requirement or only loosely bundle the agreement module with the tgt package.

@Nagasaki45
Copy link
Author

I see... Personally, considering the fact that library will usually be used in a data analysis environment I don't see a major problem in having numpy as a dependency. Otherwise, as you said, it might be better to "loosely bundle the agreement module". From what I can tell not importing it in __init__.py will solve the problem. We will have to update the docs accordingly, and maybe add a friendly message that numpy should be installed when importing the agreement module. Will be happy to submit a pull request if needed.

@mwlodarczak
Copy link
Collaborator

mwlodarczak commented Jun 26, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants