Allow .ico files on windows

haxenme · Mar 20, 2024 · 1def906 · 1def906
1 parent fa27d00
commit 1def906
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/tools/nme/src/helpers/IconHelper.hx b/tools/nme/src/helpers/IconHelper.hx
@@ -13,6 +13,7 @@ import sys.io.File;
 import sys.FileSystem;
 
 import haxe.ds.IntMap;
+using StringTools;
 
 class IconHelper 
 {
@@ -145,6 +146,15 @@ class IconHelper
 
    public static function createWindowsIcon(icons:Array<Icon>, targetPath:String, favicon = false):Bool 
    {
+      for(icon in icons)
+      {
+         if (icon.path!=null && icon.path.endsWith(".ico"))
+         {
+            FileHelper.copyFile(icon.path, targetPath);
+            return true;
+         }
+      }
+
       var sizes = [ 256, 128, 64, 48, 40, 32, 24, 16 ];
       var sizes_8bit = [ 48, 32, 16 ];
       var bmps = new Array<BitmapData>();

diff --git a/tools/nme/src/platforms/WindowsPlatform.hx b/tools/nme/src/platforms/WindowsPlatform.hx
@@ -61,7 +61,7 @@ class WindowsPlatform extends DesktopPlatform
 
          if (IconHelper.createWindowsIcon(project.icons, iconPath)) 
          {
-            outputFiles.push(ico);
+            //outputFiles.push(ico);
             var replaceVI = CommandLineTools.nme + "/tools/nme/bin/ReplaceVistaIcon.exe";
             ProcessHelper.runCommand("", replaceVI , [ executablePath, iconPath ], true, true);
          }