address types improvements, clippy bullshit #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `VAddr` and `PAddr` types to use `ptr::expose_provenance` and `ptr::with_exposed_provenance` when converting to/from raw pointers. Hopefully, this will make things a little bit less UB. Fixes #366, more or less.
This is just a bit more convenient.
This changes the `VAddr::offset` and `PAddr::offset` methods to takee an `isize` offset instead of an `i32` offset. I don't know why I used `i32` here, that was stupid. Fixes #507
Thanks, clippy!
`mycelium-pci` uses `bool::then_some` which was stabilized in Rust 1.62.0, but advertises a MSRV of 1.61.0. Whoops! Thanks to clippy for figuring that out, really cool new lint!
Mostly, but not entirely, `clippy::needless_lifetimes`.
hawkw
force-pushed
the
eliza/addr-i-hardly-knew-er
branch
from
2b16d98 to
60e089d
Compare
hawkw
added a commit
that referenced
this pull request
Jan 11, 2025
This changes the `VAddr` and `PAddr` types to use `ptr::expose_provenance` and `ptr::with_exposed_provenance` when converting to/from raw pointers. Hopefully, this will make things a little bit less UB. Fixes #366, more or less.
hawkw
added a commit
that referenced
this pull request
Jan 11, 2025
This is just a bit more convenient.
hawkw
added a commit
that referenced
this pull request
Jan 11, 2025
This changes the `VAddr::offset` and `PAddr::offset` methods to takee an `isize` offset instead of an `i32` offset. I don't know why I used `i32` here, that was stupid. Fixes #507
hawkw
added a commit
that referenced
this pull request
Jan 11, 2025
hawkw
added a commit
that referenced
this pull request
Jan 11, 2025
hawkw
added a commit
that referenced
this pull request
Jan 11, 2025
`mycelium-pci` uses `bool::then_some` which was stabilized in Rust 1.62.0, but advertises a MSRV of 1.61.0. Whoops! Thanks to clippy for figuring that out, really cool new lint!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.