refac(hal_x86_64): misc interrupt module cleanup #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, all the interrupt service routines provided by the HAL are defined inside of the `Idt::register_handlers` method. I did this initially because they're only referenced inside that method. However, this has the unfortunate side effect of making the *debug symbols* for ISRs quite unpleasant, because `register_handlers` is generic. In GDB, the symbol name for the PIT timer ISR is ```rust hal_x86_64::interrupt::<impl hal_core::interrupt::Control for hal_x86_64::interrupt::idt::Idt>::register_handlers::pit_timer_isr ```` For an example, consider [this stack trace][1], which is horrible. So, if you want to set a breakpoint on that ISR, you have to type all of that, and also remember that this is the symbol name for the ISR, and not something normal. This is annoying. Therefore, this commit moves the ISR definitions out of this method and into a top-level `hal_x86_64::interrupt::isr` module. Now, the names of these symbols should be more like this: ```rust hal_x86_64::interrupt::isr::pit_timer ``` Which seems a *lot* less unpleasant. There should be no actual functional change here besides getting nicer debug symbols. [1]: c4183db#commitcomment-150799709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.