Skip to content

Commit

Permalink
fix(hal-x86_64): don't log every MSR read
Browse files Browse the repository at this point in the history
This was a stupid thing to do, and I only did it because I was being
excessively cutesy. Now that we read the FS_GS_BASE MSR in ISRs to
access local data, this can deadlock the kernel :upside_down:
  • Loading branch information
hawkw committed Dec 31, 2024
1 parent 0ab99e8 commit 671a09d
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions hal-x86_64/src/cpu/msr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,7 @@ impl<V> Msr<V> {
options(nomem, nostack, preserves_flags)
);
}
let result = (hi as u64) << 32 | (lo as u64);
tracing::trace!(rdmsr = %self, value = fmt::hex(result));
result
(hi as u64) << 32 | (lo as u64)
}

/// Writes the given raw `u64` value to this MSR.
Expand Down

0 comments on commit 671a09d

Please sign in to comment.