improve maitake timer wheel #1333
Annotations
11 warnings
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: extractions/setup-just@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
cargo clippy:
maitake/src/time/timer.rs#L313
warning: function cannot return without recursing
--> maitake/src/time/timer.rs:313:5
|
313 | pub fn clock(&self) -> &Clock {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
314 | self.clock()
| ------------ recursive call site
|
= help: a `loop` may express intention better if this is on purpose
= note: `#[warn(unconditional_recursion)]` on by default
|
cargo clippy:
maitake/src/time/timer.rs#L314
warning: function cannot return without recursing
--> maitake/src/time/timer.rs:313:5
|
313 | pub fn clock(&self) -> &Clock {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot return without recursing
314 | self.clock()
| ------------ recursive call site
|
= help: a `loop` may express intention better if this is on purpose
= note: `#[warn(unconditional_recursion)]` on by default
|
cargo clippy:
maitake/src/time/timer/wheel.rs#L62
warning: method `now` is never used
--> maitake/src/time/timer/wheel.rs:98:19
|
62 | impl Core {
| --------- method in this implementation
...
98 | pub(super) fn now(&self) -> Ticks {
| ^^^
|
= note: `#[warn(dead_code)]` on by default
|
cargo clippy:
maitake/src/time/timer/wheel.rs#L98
warning: method `now` is never used
--> maitake/src/time/timer/wheel.rs:98:19
|
62 | impl Core {
| --------- method in this implementation
...
98 | pub(super) fn now(&self) -> Ticks {
| ^^^
|
= note: `#[warn(dead_code)]` on by default
|
cargo clippy:
maitake/src/time/clock.rs#L151
warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]`
--> maitake/src/time/clock.rs:151:1
|
151 | / pub(in crate::time) fn dur_to_ticks(
152 | | tick_duration: Duration,
153 | | dur: Duration,
154 | | ) -> Result<Ticks, TimerError> {
| |______________________________^
|
= help: either add some descriptive text or remove the attribute
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_must_use
= note: `#[warn(clippy::double_must_use)]` on by default
|
cargo clippy:
maitake/src/time/timer.rs#L313
warning: parameter is only used in recursion
--> maitake/src/time/timer.rs:313:19
|
313 | pub fn clock(&self) -> &Clock {
| ^^^^
|
note: parameter used here
--> maitake/src/time/timer.rs:314:9
|
314 | self.clock()
| ^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
= note: `#[warn(clippy::only_used_in_recursion)]` on by default
|
cargo clippy:
maitake/src/time/clock.rs#L96
warning: missing documentation for an associated function
--> maitake/src/time/clock.rs:96:5
|
96 | pub const fn new(tick_duration: Duration, now: fn() -> Ticks) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> maitake/src/time.rs:45:9
|
45 | #![warn(missing_docs, missing_debug_implementations)]
| ^^^^^^^^^^^^
|
cargo clippy:
maitake/src/time/clock.rs#L105
warning: missing documentation for a method
--> maitake/src/time/clock.rs:105:5
|
105 | pub const fn named(self, name: &'static str) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
cargo clippy:
maitake/src/time/clock.rs#L118
warning: missing documentation for a method
--> maitake/src/time/clock.rs:118:5
|
118 | pub fn tick_duration(&self) -> Duration {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
cargo clippy:
maitake/src/time/clock.rs#L123
warning: missing documentation for a method
--> maitake/src/time/clock.rs:123:5
|
123 | pub fn now(&self) -> Instant {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
The logs for this run have expired and are no longer available.
Loading