Update blog posts with instructions to deploy prometheus-operator, to…#348
Open
objectiser wants to merge 1 commit intohawkular:pagesfrom
Open
Update blog posts with instructions to deploy prometheus-operator, to…#348objectiser wants to merge 1 commit intohawkular:pagesfrom
objectiser wants to merge 1 commit intohawkular:pagesfrom
Conversation
… explain that no longer required
Contributor
Author
Member
|
I think what is a bit problematic is that there is the note and then 2 lines in the code block (without comment on the line) where people may just copy&paste those. But then those are blog posts with a date, so the note may just be fine. For documentation (not blog) I'd say remove the problematic line. |
Contributor
Author
|
+1 documentation should not reference prom-operator. So is it ok to merge as is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… explain that no longer required