IN translation 59

[cch5ng]

(update) I only tested with spanish and was relying on google to do the original language auto detection, let me know if that is an issue with other languages

basic functionality is in per #59

• added message length limit check/error
• most recent message should always display (added scrolling, it looks a little funny; maybe most recent should be on top)
• style: need to expand the height of the bubble on longer messages
• created a new route to get friend's language, required by google translate api but not previously available on FE

---

TODO

• cleanup the server logic (reduce the # times BE is getting the languages list for conversation and clean up that overall logic)
  • see if possible to return the conversation languages along with the click on contact (initiate chat) event
• do a little further testing
• (low) try to separate out socket logic from www file

[cch5ng]

caveats:

• (updated) there is not much error handling for the translation API request

  • at most I am saving the untranslated message to the db but additional error handling is not defined

• (old) some items are hard-coded like:

  • languages
  • translating language to 2 character code used by the API

[cch5ng]

this is the current flow I have used:
1 client sends message
2 server makes Google Translate API call
3 server sends updated message with translation to client
4 server saves updated message to db (only after translation unless translation fails)

would there be any reason to save a new message to the db before the translation is requested?

[sina-jamshidi]

this is the current flow I have used:
1 client sends message
2 server makes Google Translate API call
3 server sends updated message with translation to client
4 server saves updated message to db (only after translation unless translation fails)

would there be any reason to save a new message to the db before the translation is requested?

This flow makes sense. I don't think you need to save before the translation