Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IN invitation dialog 41 #46

Merged
merged 19 commits into from
May 28, 2020
Merged

IN invitation dialog 41 #46

merged 19 commits into from
May 28, 2020

Conversation

cch5ng
Copy link
Collaborator

@cch5ng cch5ng commented May 27, 2020

covers integration for

  • create a new invite (invite recipient already registered)

  • send email (sendgrid)

covers BE for

  • handle the referral link /join/:referralId (flow includes register, then create invite)

Note: for FE and IN on /join/:referralId I think there is a dependency on the existing Register component. so this can be held for that merge or handled in #44


to test

1 from authenticated app view, click the Invite Friends btn/link

  • email input should handle a list of emails, comma delimited

  • copy button should work (dependency on the current users collection)

  • send button should work (but there is a dependency that is hard coded into the component; if the users collection gets cleared, this would cause the api call to fail); the logged in user email should be available from global app state

2 from unauthenticated app view, go to this route:

/join/5ecf0a6c76a17d41288e2aa6
(this has a dependency on the current users collection, if it gets cleared, this route would work but api call would fail)

the submit() function should use a branch of logic that calls a different route

  • registers the new user

  • creates an invitation with new user as to_user_email and the user associated with the referralId (route suffix) as the from_user_email

@cch5ng cch5ng changed the title IN invitation dialog 41 [in progress] IN invitation dialog 41 May 27, 2020
@cch5ng cch5ng changed the title [in progress] IN invitation dialog 41 IN invitation dialog 41 May 28, 2020
@cch5ng
Copy link
Collaborator Author

cch5ng commented May 28, 2020

I think the requirements functionality has been completed. the authenticated app view looks pretty ugly, should I spend time to clean it up? thanks

@sina-jamshidi
Copy link

I think the requirements functionality has been completed. the authenticated app view looks pretty ugly, should I spend time to clean it up? thanks

Yeah maybe just the basics of the layout. It doesn't have to be super pretty but just so that the different sections can be differentiated

@cch5ng cch5ng merged commit c4d008f into dev May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants