-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.4 VSCode Extension, Live Interviewing Features #2
base: main
Are you sure you want to change the base?
Conversation
src/extension.ts
Outdated
|
||
// Initialize variables | ||
const workspace = vscode.workspace.workspaceFolders?.[0]; | ||
const sessionId = workspace?.name || ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: this should eventually hook up the API here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this actually wouldn't be calling the API, but instead it's more likely that it would be passed in as an environment variable. So, I would change this to use an env var called SESSION_ID
instead, and confirm it's the right one when you pass it in via docker. You might want to set up an env var file of some sort, because there will be other actions using env vars later.
So actually I realize it only rendered the file decoration if a file is open on that main editor view 😓 So in this example, on the side Screen.Recording.2023-10-11.at.11.10.31.AM.movI don't think it would be ideal UI that we automatically open all the files for them and clog their tab view. I think the automatically open file was a quick solution to what Shums initially have if someone moved the cursor
Update: hmm seems like we already use |
@ThinkTink Here is the fix with the auto open! Screen.Recording.2023-10-11.at.2.13.24.PM.mov |
General repo comments:
|
Cursor movements + file clicked
Screen.Recording.2023-10-06.at.11.27.39.PM.mov
Testing