Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4 VSCode Extension, Live Interviewing Features #2

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

cassandrale179
Copy link
Contributor

@cassandrale179 cassandrale179 commented Oct 7, 2023

Cursor movements + file clicked

Screen.Recording.2023-10-06.at.11.27.39.PM.mov

Testing

  • Follow instructions on README.md to install extensions and test
  • VSCode automatically only open 1 workspace per folder. To create two workspaces, do ⌘ + Shift + P to open Command Palette then select "Workspaces: duplicate as workspace in new window"

server/index.js Outdated Show resolved Hide resolved
src/extension.ts Outdated

// Initialize variables
const workspace = vscode.workspace.workspaceFolders?.[0];
const sessionId = workspace?.name || "";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: this should eventually hook up the API here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this actually wouldn't be calling the API, but instead it's more likely that it would be passed in as an environment variable. So, I would change this to use an env var called SESSION_ID instead, and confirm it's the right one when you pass it in via docker. You might want to set up an env var file of some sort, because there will be other actions using env vars later.

src/SidebarProvider.ts Outdated Show resolved Hide resolved
@cassandrale179 cassandrale179 changed the base branch from welcome to main October 10, 2023 12:49
src/extension.ts Outdated Show resolved Hide resolved
server/index.js Outdated Show resolved Hide resolved
src/FileDecorationProvider.ts Outdated Show resolved Hide resolved
src/SidebarProvider.ts Outdated Show resolved Hide resolved
src/SidebarProvider.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
@cassandrale179
Copy link
Contributor Author

cassandrale179 commented Oct 11, 2023

What specifically changes after someone has opened a file once vs not? Is there a way we could pre-initialize all the files as opened or something?

So actually I realize it only rendered the file decoration if a file is open on that main editor view 😓

So in this example, on the side a4.txt and a5.txt is already opened, so the decorator is reflected. But if those tabs are not active editor, like a9.txt isn't rendered because it's not active 😓

Screen.Recording.2023-10-11.at.11.10.31.AM.mov

I don't think it would be ideal UI that we automatically open all the files for them and clog their tab view.

I think the automatically open file was a quick solution to what Shums initially have if someone moved the cursor

It appear there is [onDidChangeFileDecorations](https://code.visualstudio.com/api/references/vscode-api#FileDecorationProvider.onDidChangeFileDecorations)-event. I can try to look into researching that if we don't want the quick fix solution.

Update: hmm seems like we already use onDidChangeFileDecorations at this.onDidChangeFileDecorations = this.emitter.event 🤔

Screen Shot 2023-10-11 at 11 18 58 AM

@cassandrale179
Copy link
Contributor Author

@ThinkTink Here is the fix with the auto open!

Screen.Recording.2023-10-11.at.2.13.24.PM.mov

@cassandrale179 cassandrale179 changed the title Socket 1.4 VSCode Extension, Live Interviewing Features Oct 11, 2023
@etchao
Copy link
Contributor

etchao commented Oct 12, 2023

General repo comments:

  • I think main needs to be merged in, since it looks like out/ is committed in this PR
  • dist/ and *.vsix should be added to .gitignore as well (you'll need to commit the deletion of those files as well)
  • Right before merging, remember to bump the version in package.json to match the version this merge will have 😅
    • This will be annoying to remember so eventually I imagine we'll have some sort of auto-increment GitHub Action to handle it, but obviously that's not priority

package.json Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants