-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribution RFC #98
Open
sordina
wants to merge
16
commits into
main
Choose a base branch
from
lyndon/distribution-rfc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Distribution RFC #98
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cff6362
Distribution RFC
sordina 08b2e82
More details
sordina f15953b
WIP
sordina d92c446
WIP
sordina 96b6f1f
WIP
sordina 7f49afb
revocation concerns
sordina 094f085
WIP
sordina c6451c6
follow-up-actions
sordina 8c31ba4
title update
sordina ad433cf
moving purpose higher in document
sordina 75357f3
heading levels
sordina 07446ff
rationale
sordina 44d54f8
milestones
sordina ed19027
roadmap
sordina 09dc469
example MD change for MS 1
sordina 11330f0
update
sordina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,32 @@ The following are not described in this specification: | |
* Verification policies and procedures | ||
|
||
|
||
## Motivation and Why and How this Differs from Existing Solutions | ||
|
||
First, where are the current and proposed system different? | ||
|
||
| Layer | Current System | Proposed System | Difference | | ||
| --- | --- | --- | --- | | ||
| Package Definition Storage | Github Tag | .tar.gz | Currently the package definitions are stored in a directory hierarchy on a github branch/tag | | ||
| Database | Postgres | Postgres | Same infrastructure with a new schema | | ||
| API | Hasura | Hasura | Same infrastructure with different roles and actions | | ||
| CLI | N/A | Hasura V3 CLI Plugin | No current CLI interactions available | | ||
| Registry | ndc-hub/registry | No central component in proposal | There is no central definition source outside of the DB/Storage layer in the proposal | | ||
| Third-party CI | No current component | Usage via CLI/API | Third-parties are able to integrate into their CI via API | | ||
| Topic Scraping | No current component | Scheduled/Webhook trigger of topic ingestion of community connectors | Arbitrary ingestion is possible via the API/CLI | | ||
|
||
The current system's GraphQL: https://data.pro.arusah.com/ - Looking at all the graphql queries starting with connector_ should give all the things that we have so far. | ||
|
||
Google cloud function (https://github.com/hasura/connectors-cloud-integration/tree/main/sync_connector_hub_data) runs every 24 hours and scrapes registry and inserts into DB. | ||
|
||
Issues with the current system: | ||
|
||
* Pull-based ingestion of registry - Changes should ideally propagate instantaneously | ||
* No ability to treat connectors independently - Need to PR to central registry | ||
* Artefacts are not distributable outside of Github references - Tied to Github | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there's a simple workaround for this - link to the release tarball on GitHub, or any other tarball hosted anywhere else. |
||
* TODO | ||
|
||
|
||
## Proposal | ||
|
||
While the precursor specifications outline the structure and mechanisms of packaging, this RFC details how the packages are owned, distributed, and indexed. A layered solution is outlined from storage up to user-applications and how they can be leveraged by CI in order to automatically publish updated versions and scrape topics for community contribution discovery. | ||
|
@@ -61,6 +87,7 @@ This solution enables the following UX scenarios: | |
* Packages are referenced in Hasura V3 projects | ||
* Packages are fetched for local usage in Hasura V3 projects | ||
|
||
|
||
### Ownership | ||
|
||
Ownership is granted on an Organisation -> Package -> Author -> Version hierarchy. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we fix this by running the job more frequently, or in a commit hook?