Disable use of private reverse DNS servers by default #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the one picked is the Home Assistant internal DNS plug-in (CoreDNS server), which depending on configuration might lead to a DNS loop. Users should configure explicitly a private reverse DNS server. Disable the feature by default.
|
Potential better solution here would be to read DNS servers from Supervisor, and if it is not the Home Assistant host itself, enable the feature and set the local DNS server using |
frenck
approved these changes
Apr 5, 2024
frenck
added
the
bugfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Currently, the one picked is the Home Assistant internal DNS plug-in (CoreDNS server), which depending on configuration might lead to a DNS loop.
Users should configure explicitly a private reverse DNS server. Disable the feature by default.
Related Issues
#501