Rely on gitignore to exclude listed files in ghcide (#4665) #4736
+26
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackheaven
force-pushed
the
ghcide/use-gitignore
branch
2 times, most recently
from
013cd7b to
5db38c5
Compare
|
I don't think the CI failure is related to my PR. |
Looks like a flaky thing, it fixed itself |
blackheaven
force-pushed
the
ghcide/use-gitignore
branch
from
5db38c5 to
4b705d1
Compare
|
Thanks, let's try again |
fendor
requested changes
Oct 28, 2025
| recurse y | "." `isPrefixOf` takeFileName y = False -- skip .git etc | ||
| recurse y = takeFileName y `notElem` ["dist", "dist-newstyle"] -- cabal directories | ||
| in filter (\y -> takeExtension y `elem` [".hs", ".lhs"]) <$> IO.listFilesInside (return . recurse) x | ||
| (testGitExitCode, _, _) <- readProcessWithExitCode "git" ["status"] "" |
There was a problem hiding this comment.
What happens if git is not installed?
There was a problem hiding this comment.
it should fallback to the current implementation
|
|
||
| expandFiles :: [FilePath] -> IO [FilePath] | ||
| expandFiles = concatMapM $ \x -> do | ||
| expandFiles paths = do |
There was a problem hiding this comment.
As the behaviour got more complicated, could you expand the documentation of what this function does?
blackheaven
force-pushed
the
ghcide/use-gitignore
branch
from
3ef4d76 to
7957387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aimes to fix #4665.
Note that I directly calling
git, as thgitignoreformat is non-trivial.I can roll a partial parsing implementation if requested.