Skip to content

Fix warning for -Werror build in Circle CI #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

Fix warning for -Werror build in Circle CI #4727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
843b88c
Fix typo in hls-signature-help-plugin
fendor Sep 15, 2025
199da23
Remove unused import
fendor Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/hls-signature-help-plugin/src/Ide/Plugin/SignatureHelp.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ help when a space char is inserted, we probably have to use up-to-date results.

{-
Here is a brief description of the algorithm of finding relevant bits from HIE AST
1. let 'hsAppNode' = the smallest 'HsApp' AST node which contains the cursor postion
1. let 'hsAppNode' = the smallest 'HsApp' AST node which contains the cursor position
See 'extractInfoFromSmallestContainingFunctionApplicationAst'
2. let 'functionNode' = the left-most node of 'hsAppNode'
See 'getLeftMostNode'
Expand Down
1 change: 0 additions & 1 deletion plugins/hls-signature-help-plugin/test/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import Control.Arrow ((>>>))
import Control.Exception (throw)
import Control.Lens ((^.))
import Data.Maybe (fromJust)
import Data.String.Interpolate (__i)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and sorry for the extra work.

I am aware that this import line is redundant after #4717 is merged. However, I am surprised that this causes CI failures since the circleci check did pass before I merged #4626.

I have done some digging and found the cause. The default behavior of GitHub's actions/checkout is merging the PR branch and the target branch. On the contrary, the default behavior of circleci's checkout does not do the merge. Both of them can be configured to change to another behavior. Here is GitHub's doc. I do not find the doc of circleci, but it should be doable.

It is debatable whether we should do the merge in the checkout action or not. However, having different behaviors in different CI checks is just wrong, I think. We should choose one single checkout behavior for all CI checks.

related: https://www.github.com/actions/checkout/issues/504

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to migrate away from CircleCI as there is no reason to have CircleCI and GHA. The main issue so far was that we are limited by our caches, we only have 10GB, and our current jobs fill this quota by far. In fact, we are usually not hitting caches for at least one job because they were already evicted.
In the release CI, there is a cabal-cache process that backs up CI artefacts to a s3 buckets, perhaps we want to do something similar for regular CI jobs. We can't use the same existing s3 buckets, as we are only borrowing them.

import Data.Text (Text)
import qualified Data.Text as T
import Development.IDE.Plugin.Completions.Types (PosPrefixInfo (PosPrefixInfo))
Expand Down
Loading