Skip to content

CI: Fix hls-eval-plugin tests for GHC-9.10 #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Jun 19, 2025

hls-eval-plugin tests are currently failing in CI with:

Test output was different from 'plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs'. Output of ["git","-c","core.fileMode=false","diff","--no-index","--text","--exit-code","plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs","/tmp/TPropertyError.ghc910.expected89418-27.actual"]:
    diff --git a/plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs b/tmp/TPropertyError.ghc910.expected89418-27.actual
    index e3208e3..87fbda0 100644
    --- a/plugins/hls-eval-plugin/test/testdata/TPropertyError.ghc910.expected.hs
    +++ b/tmp/TPropertyError.ghc910.expected89418-27.actual
    @@ -10,4 +10,8 @@ module TProperty where
     --     errorEmptyList, called at libraries/ghc-internal/src/GHC/Internal/List.hs:96:11 in ghc-internal:GHC.Internal.List
     --     badHead, called at libraries/ghc-internal/src/GHC/Internal/List.hs:90:28 in ghc-internal:GHC.Internal.List
     --     head, called at <interactive>:1:27 in interactive:Ghci2
    +--   HasCallStack backtrace:
    +--     collectBacktraces, called at libraries/ghc-internal/src/GHC/Internal/Exception.hs:92:13 in ghc-internal:GHC.Internal.Exception
    +--     toExceptionWithBacktrace, called at libraries/ghc-internal/src/GHC/Internal/Exception.hs:128:3 in ghc-internal:GHC.Internal.Exception
    +--   
     -- []

This change fixes the failing test

@sgillespie sgillespie changed the title WIP: CI: Fix hls-eval-plugin tests for GHC-9.10 CI: Fix hls-eval-plugin tests for GHC-9.10 Jun 19, 2025
@sgillespie sgillespie marked this pull request as ready for review June 20, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant