Skip to content

CI: linting#2538

Merged
mergify[bot] merged 5 commits intohaskell:masterfrom
Anton-Latukha:2021-12-25-ci-lint
Dec 26, 2021
Merged

CI: linting#2538
mergify[bot] merged 5 commits intohaskell:masterfrom
Anton-Latukha:2021-12-25-ci-lint

Conversation

@Anton-Latukha
Copy link
Copy Markdown
Collaborator

@Anton-Latukha Anton-Latukha commented Dec 25, 2021

No description provided.

@Anton-Latukha
Copy link
Copy Markdown
Collaborator Author

Anton-Latukha commented Dec 25, 2021

[skip circleci]

jneira
jneira approved these changes Dec 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner this way, thanks!

@Anton-Latukha
Copy link
Copy Markdown
Collaborator Author

Anton-Latukha commented Dec 25, 2021

I mainly do this for paths blocks, as they have advanced logic & so being able to read & parse them is useful.

@Anton-Latukha Anton-Latukha added the merge me Label to trigger pull request merge label Dec 25, 2021
@Anton-Latukha Anton-Latukha marked this pull request as ready for review December 25, 2021 20:55
@Anton-Latukha
Copy link
Copy Markdown
Collaborator Author

Anton-Latukha commented Dec 25, 2021

Oh. CI can not merge. It is me.

I pushed & then dropped the last commits, & seems CI got puzzled, some workflows appeared twice.

@Anton-Latukha
Copy link
Copy Markdown
Collaborator Author

Anton-Latukha commented Dec 25, 2021

Hmm...

@Anton-Latukha
Copy link
Copy Markdown
Collaborator Author

Anton-Latukha commented Dec 25, 2021

@jneira maybe you know what this means:
Screenshot-2021-12-26-00:39:45

HLint workflow passes, but there is a branch protection check, maybe it does not catch the HLint (or HLint workflow needs something) or something?

@Anton-Latukha
Copy link
Copy Markdown
Collaborator Author

Anton-Latukha commented Dec 25, 2021 •
edited
Loading

I had to add hlint_post_job or something?

@Anton-Latukha Anton-Latukha marked this pull request as draft December 25, 2021 23:14
@Anton-Latukha
Copy link
Copy Markdown
Collaborator Author

Anton-Latukha commented Dec 25, 2021

The same is in: #2527

@Ailrun
Copy link
Copy Markdown
Member

Ailrun commented Dec 26, 2021

The branch protection rule is global so the same rule applies to all PRs. It should work without any extra "post" jobs, so it seems strange that CI doesn't check the passed job... Let's disable the requirement for now.

@Ailrun Ailrun marked this pull request as ready for review December 26, 2021 11:22
@mergify mergify Bot merged commit b354202 into haskell:master Dec 26, 2021
@jneira
Copy link
Copy Markdown
Member

jneira commented Dec 26, 2021

I think it is working now, will enable again

@jneira
Copy link
Copy Markdown
Member

jneira commented Dec 26, 2021

I think it is working now, will enable again

nope there are 2 checks, and GH does not know they are the same

@Anton-Latukha
Copy link
Copy Markdown
Collaborator Author

Anton-Latukha commented Dec 26, 2021

@Ailrun

Thanks.

I did workflows the default way & not familiar with what's happening there & those processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jneira jneira jneira approved these changes

Assignees

No one assigned

Labels

merge me Label to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Anton-Latukha @Ailrun @jneira