-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor happyDoActions #280
Conversation
c6a4bc4
to
d5bbb82
Compare
I rebased and added a commit fixing the tests. Feel free to squash the changes in the commits where they belong. |
d5bbb82
to
dfdc863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh. I just realised I had the following comments stuck in the review queue which we should discuss.
dfdc863
to
faae80f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a closer look at how WORDS_BIGENDIAN
is to be used. alex
simply pulls it from the GHC-provided header ghcconfig.h
. So we need to add the following line to the begin of the template (after the GHC check):
#include "ghcconfig.h"
After that, we still need to add an emulated CI pipeline as suggested by @Bodigrim here: haskell/alex#260 (comment). I can do that as well, but probably not within the next 2 weeks.
There are several possible headers; I don't remember why but I think at some point we concluded that There is also |
faae80f
to
1447b5d
Compare
1447b5d
to
73465de
Compare
73465de
to
026cd35
Compare
026cd35
to
d8a3db6
Compare
Alright, I included |
This PR refactors happyDoActions into several smaller functions, changes how the parsing tables are constructed, using 32-bit integers instead of 16-bit integers.