Generate dockerfiles #69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlistairB
force-pushed
the
template-dockerfiles
branch
from
9363458 to
964c3ec
Compare
|
Just going to close this I don't have the time and it is a fairly minor win. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65
The dockerfiles have a lot of duplication with them. Let's generate them instead using templates and haskell.
As part of this let's switch to using
buildpack-depswhich will slightly increase the size of the images, but has a much higher chance of being cached as it is very common in official images. Also the main debian images become more batteries included.