Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Stack version to 3.3.1, which is now the recommended ghcup version.
- Update the ARG STACK value from 3.1.1 to 3.3.1.
- Update corresponding SHA256 checksum values for both 'aarch64' and 'x86_64' architectures.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| 9.8/slim-bullseye/Dockerfile | Upgraded Stack version and updated SHA256 checksums. |
| 9.8/bullseye/Dockerfile | Upgraded Stack version and updated SHA256 checksums. |
| 9.6/slim-bullseye/Dockerfile | Upgraded Stack version and updated SHA256 checksums. |
| 9.6/bullseye/Dockerfile | Upgraded Stack version and updated SHA256 checksums. |
| 9.10/slim-bullseye/Dockerfile | Upgraded Stack version and updated SHA256 checksums. |
| 9.10/bullseye/Dockerfile | Upgraded Stack version and updated SHA256 checksums. |
Comments suppressed due to low confidence (12)
9.8/slim-bullseye/Dockerfile:26
- Ensure the upgraded Stack version (3.3.1) is intentional and in line with ghcup recommendations. Consider adding a comment linking to the official release notes for future reference.
+ARG STACK=3.3.1
9.8/slim-bullseye/Dockerfile:36
- Verify that the updated SHA256 checksum for the 'aarch64' architecture correctly corresponds to Stack 3.3.1. Including the source URL for the checksum can aid maintainability.
+ STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';
9.8/bullseye/Dockerfile:26
- Ensure the upgraded Stack version (3.3.1) is intentional and documented. Consider adding a reference comment to the official release notes.
+ARG STACK=3.3.1
9.8/bullseye/Dockerfile:36
- Verify that the updated SHA256 checksum for the 'aarch64' architecture is correct for Stack 3.3.1. A comment with the checksum source can help future reviews.
+ STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';
9.6/slim-bullseye/Dockerfile:26
- Confirm that the upgrade to Stack 3.3.1 is deliberate and that related documentation is updated accordingly. Linking to release notes might improve clarity.
+ARG STACK=3.3.1
9.6/slim-bullseye/Dockerfile:36
- Ensure that the SHA256 checksum update for 'aarch64' is correct for the new Stack version. Adding a reference to the checksum source may help maintainability.
+ STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';
9.6/bullseye/Dockerfile:26
- Double-check that the update to Stack 3.3.1 is intended and aligns with upstream recommendations. A brief comment with the release reference could be beneficial.
+ARG STACK=3.3.1
9.6/bullseye/Dockerfile:36
- Verify that the updated SHA256 checksum for the 'aarch64' architecture is sourced from the official Stack 3.3.1 release. Including this reference as a comment may aid future maintenance.
+ STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';
9.10/slim-bullseye/Dockerfile:26
- Ensure the update to Stack 3.3.1 is intentional and that any related documentation is updated. A comment with a link to the release notes would be helpful.
+ARG STACK=3.3.1
9.10/slim-bullseye/Dockerfile:36
- Make sure the new SHA256 checksum for 'aarch64' is accurate for Stack 3.3.1. Including the official checksum source as a comment is recommended for clarity.
+ STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';
9.10/bullseye/Dockerfile:26
- Confirm that the change to Stack 3.3.1 is correct and that related documentation reflects this update. A reference comment for the official release notes could be useful.
+ARG STACK=3.3.1
9.10/bullseye/Dockerfile:36
- Ensure the updated SHA256 checksum for 'aarch64' matches the official value for Stack 3.3.1. Adding a comment with the source of this checksum can improve maintainability.
+ STACK_SHA256='bdd618ea5a9c921417727011f2ecd78987dffa5cee5e741108baf65a9b5b58ab';
develop7
reviewed
May 14, 2025
Collaborator
develop7
left a comment
There was a problem hiding this comment.
Thanks! Sorry I've missed it
develop7
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. which is now the ghcup - recommended version to use