Additional version bound checks #10554
Draft
+165
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philderbeast
force-pushed
the
fix/check-version-bounds
branch
from
e090e69
to
b451782
Compare
ffaf1
reviewed
Nov 18, 2024
Comment on lines
+152
to
+158
| -- | Is the version range without an upper bound? | ||
| withoutUpperBound :: Dependency -> Bool | ||
| withoutUpperBound (Dependency _ ver _) = not . hasUpperBound $ ver | ||
|
|
||
| -- | Is the upper bound version range LEQ (less or equal, <=)? | ||
| leqUpperBound :: Dependency -> Bool | ||
| leqUpperBound (Dependency _ ver _) |
There was a problem hiding this comment.
Have you considered moving this to Distribution.Types.Dependency?
Not a request, just want to know what your thoughts about it are.
Comment on lines
+726
to
+734
| isTrailingZeroUpperBound :: C.PackageCheck -> Bool | ||
| isTrailingZeroUpperBound pc = case C.explanation pc of | ||
| C.TrailingZeroUpperBounds{} -> True | ||
| _ -> False | ||
| isLeqUpperBound :: C.PackageCheck -> Bool | ||
| isLeqUpperBound pc = case C.explanation pc of | ||
| C.LEQUpperBounds{} -> True | ||
| _ -> False | ||
| isgtLowerBound :: C.PackageCheck -> Bool |
There was a problem hiding this comment.
Is there a reason to hav multiple functions instead of one? (isBoundCheck or similar)
| Please avoid trailing zeros for upper bounds. There is more information at https://pvp.haskell.org/ | ||
| Warning: [greater-than-lower-bounds] On library, these packages have greater than (>) lower bounds: | ||
| - base | ||
| Please use greater than or equals (>=) for lower bounds. There is more information at https://pvp.haskell.org/ |
There was a problem hiding this comment.
The message is very good, but does PVP actually explains clearly why we would need such and such bounds? Maybe it is/was/will be in the FVP FAQ?
| @@ -1,3 +1,5 @@ | |||
| {-# LANGUAGE ViewPatterns #-} | |||
There was a problem hiding this comment.
Where is this needed? How verbose would this PR become without it?
| @@ -116,34 +122,58 @@ partitionDeps ads ns ds = do | |||
| -- for important dependencies like base). | |||
| checkPVP | |||
| :: Monad m | |||
| => (String -> PackageCheck) -- Warn message dependend on name | |||
| => (Dependency -> Bool) | |||
There was a problem hiding this comment.
Why are we passing a new function?
|
And of course, if something is not clear in the checks scaffold, ask! |
|
Converted to draft as I think there's more work to do: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9806. Checks that lower bounds are inclusive, upper bounds are exclusive and don't have trailing zeros.
significance: significantin the changelog file.