Make a trailing colon for stanzas a parse failure #10525
+85
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
force-pushed
the
field-stanza-names
branch
from
dfdef66
to
62da1e0
Compare
9999years
force-pushed
the
field-stanza-names
branch
from
62da1e0
to
f34aba9
Compare
Here's a mistake I make semi-regularly:
source-repository-package:
type: git
location: https://github.com/parsonsmatt/foundation
tag: 688c32ccd9a951bc96dd09423a6e6684f091d510
subdir: basement
subdir: foundation
Cabal treats this as a warning, so it prints:
Warning: cabal.project: Unrecognized field
'source-repository-package' on line 52
This is fine (if you already know the mistake you've made, at least!),
but it's very easy to miss amidst lots of output.
I often re-run `cabal` when I see a ton of output to attempt to get a
smaller error message. (Usually it works and I get an error message
that's got less "compiling module such and such" noise in it.) However,
re-running `cabal` will discard this warning entirely!
Let's make it a hard error instead. This is a backwards-compatibility
break.
9999years
force-pushed
the
field-stanza-names
branch
from
f34aba9
to
f112421
Compare
|
Added a test case and a release note, ready for review! |
geekosaur
approved these changes
Nov 19, 2024
|
|
||
| main = cabalTest $ do | ||
| result <- fails $ cabal' "build" [] | ||
| assertOutputContains "Error parsing project file" result |
There was a problem hiding this comment.
I wonder if these should start using error numbers. (That might be a separate PR, though.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a mistake I make semi-regularly:
Cabal treats this as a warning, so it prints:
This is fine (if you already know the mistake you've made, at least!), but it's very easy to miss amidst lots of output.
I often re-run
cabalwhen I see a ton of output to attempt to get a smaller error message. (Usually it works and I get an error message that's got less "compiling module such and such" noise in it.) However, re-runningcabalwill discard this warning entirely!Let's make it a hard error instead. This is a backwards-compatibility break.
Now, it prints this error: