Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repl --keep-temp-files test with custom Setup.hs #10391

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Add repl --keep-temp-files test with custom Setup.hs #10391

merged 1 commit into from
Oct 3, 2024

Conversation

9999years
Copy link
Collaborator

@9999years 9999years commented Sep 27, 2024 •
edited
Loading

Split off of #10292

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Depends-on: #10388

geekosaur
geekosaur approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been adding Depends-on: headers to these PRs so Mergify will know about the dependencies.

@9999years 9999years force-pushed the wiggles/add-repl-keep-temp-files-test-custom-setup branch from c4eda1a to 54e6268 Compare September 27, 2024 23:17
@9999years 9999years mentioned this pull request Sep 28, 2024
Merged
5 tasks
@9999years 9999years force-pushed the wiggles/add-repl-keep-temp-files-test-custom-setup branch 2 times, most recently from af824b4 to 01c03ab Compare September 30, 2024 21:38
@9999years 9999years marked this pull request as ready for review September 30, 2024 23:22
@mergify mergify bot added the ready and waiting Mergify is waiting out the cooldown period label Oct 1, 2024
@9999years 9999years added merge me Tell Mergify Bot to merge and removed merge+no rebase labels Oct 1, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 3, 2024
@9999years 9999years force-pushed the wiggles/add-repl-keep-temp-files-test-custom-setup branch from 01c03ab to 878a019 Compare October 3, 2024 16:45
@9999years
Copy link
Collaborator Author

Rebased for branch permissions.

@mergify mergify bot merged commit 3667756 into haskell:master Oct 3, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekosaur geekosaur geekosaur approved these changes

@mpickering mpickering Awaiting requested review from mpickering

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge merge+no rebase ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9999years @mpickering @geekosaur