Point out validate.sh more prominently in CONTRIBUTING.md#10330
Conversation
|
Pointing that Adding a sentence or a paragraph feels better. Something like “You can also run all tests locally using |
ulysses4ever
left a comment
There was a problem hiding this comment.
to Francesco's point: I think it's good enough. But if someone feels strong about it, they should feel free to "request changes".
|
It might be worth pointing out that, especially with the |
|
Yes, my suggestion is to:
This way we should be clear and immediate enough for all use cases. |
93a4657 to
6c2b6c3
Compare
|
I've addressed comments & made the headings uniform. (Use the rich diff to see changes.) |
6c2b6c3 to
1d57a33
Compare
The
CONTRIBUTING.mdmakes it sound really hard to run tests locally, but actuallyvalidate.shworks fine!validate.shstill needs work (see the list in #10320) for example, but it's a great starting point.