Nar module cleanups #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nar handling, and Nix in general, only really makes sense in the context of Unix-style file paths. And even outside of Unix land, FilePath is a bad interface. This commit also moves narEffectsIO into a local definition in the test suite, to avoid a unix dependency in the core library. This should eventually be moved into a separate library (and defined directly in terms of the RawFilePath operations).
|
Still a draft, will mark ready once the module is up to spec |
imalsogreg
requested changes
Mar 23, 2019
| } | ||
|
|
||
|
|
||
| -- Directly taken from Eelco thesis |
There was a problem hiding this comment.
Do we know what this comment was referring to? The whole module, Nar effects? Probably not the Nar newtype.
|
|
||
| putContents :: Int64 -> BSL.ByteString -> B.Put | ||
| putContents fSize bs = str "contents" <> int fSize <> (pad fSize bs) | ||
| -- putContents fSize bs = str "contents" <> int (BSL.length bs) <> (pad fSize bs) |
|
(meta). Does |
|
Draft means I'm still expecting more to come (in particular, so far I've only touched NarEffects and still need to go through the rest and add haddocks etc.), but still ready for comments on what's come so far. Also, I'm trying to make to so every commit is in a workable state, so that if someone wants to depend on this before I'm done we can merge in and I can continue the rest later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.