Fix overlapping errors and improve diagnostics #198
+6
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is similar to:
#178
The existing code has overlapping instances, namely for:
(l :+: r)
and(C1 (...) :+: r)
The second instance is unnecessary, since the instance for
C1 (...) (S1 sa sb)
will produce a type error already.Some code that triggers the overlapping instances error:
Also an unary constructor is one that takes one argument, so I took the liberty to rename the diagnostics to nullary constructors.
A test case would be a bit more difficult because it still fails compilation.