Skip to content

Use modified setup for building vendored libsecp256k1 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

IvantheTricourne
Copy link

No description provided.

IvantheTricourne and others added 8 commits April 20, 2023 20:06

Verified

This commit was signed with the committer’s verified signature.
iostat Ilya Ostrovskiy

Verified

This commit was signed with the committer’s verified signature.
iostat Ilya Ostrovskiy
…s, and enable schnorr as this lib has bindings to it

Verified

This commit was signed with the committer’s verified signature.
iostat Ilya Ostrovskiy
…whereas the HEAD that was submoduled is... well, master...

Verified

This commit was signed with the committer’s verified signature.
iostat Ilya Ostrovskiy
… dep in travis since we're building our own

Verified

This commit was signed with the committer’s verified signature.
iostat Ilya Ostrovskiy
…precations since Prim marks them as well

Verified

This commit was signed with the committer’s verified signature.
iostat Ilya Ostrovskiy

Verified

This commit was signed with the committer’s verified signature.
iostat Ilya Ostrovskiy
@prolic
Copy link

prolic commented Sep 27, 2024

this would be really great!

@prolic
Copy link

prolic commented Oct 1, 2024

@ProofOfKeags what's missing to push this forward? I'm happy to assist, if I can.

@ProofOfKeags
Copy link
Collaborator

Is this just making it so that we build libsecp256k1 from source?

@prolic
Copy link

prolic commented Oct 1, 2024

I only skimmed it briefly, but it looks to me like building from source instead of relying on some pre-installed library. I'd love to see this, especially since libsecp256k1 is now shipped on many linux platforms, but without schnorr signatures. So it becomes less of a hassle to setup locally.

@ProofOfKeags
Copy link
Collaborator

I'll build and test today or tomorrow.

@prolic
Copy link

prolic commented Oct 3, 2024

Does this work on all platforms or is it Linux only? Would be absolutely awesome to be able to just cabal install this lib and it just works on all platforms.

@ProofOfKeags
Copy link
Collaborator

Does this work on all platforms or is it Linux only? Would be absolutely awesome to be able to just cabal install this lib and it just works on all platforms.

I can only test for MacOS right now.

@prolic
Copy link

prolic commented Oct 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants