Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: ActionMailers with keyword args fail in Ruby 3.2.1 #202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcrohloff
Copy link
Contributor

This fixes an issue where mailer methods defined with keyword args like def test(user, notes:) fail with Ruby 3.2.1 and Rails 7.0.4

@mattpolito
Copy link
Member

mattpolito commented Apr 14, 2023

@marcrohloff Thanks for the PR, however I think we'd be better off to cut a new release that removes support for Ruby < 3. 2.7 is at end of life.

Also, do you have a scenario where this is failing or can you add a test case?

@marcrohloff
Copy link
Contributor Author

@mattpolito The existing Mailer hello_bird test fails under Ruby 3.2.1 without the patch

I agree that it would be good to remove support for earler Ruby (and Rails) versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants