Skip to content

[TFDN-182] TFE ToolVersion API Doc Updates for ARM Support #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

kelsi-hoyle
Copy link
Collaborator

@kelsi-hoyle kelsi-hoyle commented Jul 7, 2025

This PR updates the tool version API docs to reflect the addition of the archs field and the recommendation of arch[n].url and arch[n].sha usage over the soon to be deprecated fields, url and sha.

Jira
RFC

Copy link

github-actions bot commented Jul 7, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Mon Jul 14 22:56:55 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Mon Jul 14 22:51:24 UTC 2025

Copy link

github-actions bot commented Jul 7, 2025

Broken Link Checker

No broken links found! 🎉

@natalie-todd natalie-todd marked this pull request as ready for review July 11, 2025 19:44
@natalie-todd natalie-todd requested review from a team as code owners July 11, 2025 19:44
@natalie-todd natalie-todd force-pushed the kelsi-hoyle/TFDN-182/arm-support-updates branch from 46114ec to 9384b3b Compare July 11, 2025 19:53
@natalie-todd natalie-todd requested a review from radditude July 11, 2025 20:07
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions and linked to the style guide for my rationale. But just to sum up, I don't believe we have a concept of a "pre-deprecation" cycle, so until something is actually deprecated, I think the most we can say is that something is under review. "Deprecated soon" is too much of a hedge.

natalie-todd and others added 7 commits July 14, 2025 14:58
…s/admin/sentinel-versions.mdx

Co-authored-by: trujillo-adam <[email protected]>
…s/admin/sentinel-versions.mdx

Co-authored-by: trujillo-adam <[email protected]>
…s/admin/sentinel-versions.mdx

Co-authored-by: trujillo-adam <[email protected]>
…s/admin/terraform-versions.mdx

Co-authored-by: trujillo-adam <[email protected]>
…s/admin/terraform-versions.mdx

Co-authored-by: trujillo-adam <[email protected]>
…s/admin/terraform-versions.mdx

Co-authored-by: trujillo-adam <[email protected]>
…s/admin/terraform-versions.mdx

Co-authored-by: trujillo-adam <[email protected]>
@natalie-todd natalie-todd force-pushed the kelsi-hoyle/TFDN-182/arm-support-updates branch from 6cef466 to d69f60c Compare July 14, 2025 22:32
@natalie-todd natalie-todd force-pushed the kelsi-hoyle/TFDN-182/arm-support-updates branch from d69f60c to d587190 Compare July 14, 2025 22:38
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants