-
Notifications
You must be signed in to change notification settings - Fork 16
Improve clarity on gitlab ee / ce webhook configurations #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Vercel Previews Deployed
|
I would also imagine that this should be back-ported into previous versions, but I wanted to ensure the wording was acceptable before doing a mass edit back in time! |
Broken Link CheckerNo broken links found! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wording is identical, what is added is a header in the troubleshooting section that provides details on the error message. This is great because it could help customers search for the issue more easily.
Thank you!
Please evaluate the targets for backporting.
EDIT: Upon reflection, I believe we do not need to backport this change. The change is merely stylistic / adding further context - which is great. But the information is already available in previous releases.
So I suggest: Lets pragmatically not backport :)
@@ -84,6 +84,12 @@ This usually happens when an SSH key isn't associated with the VCS provider's OA | |||
|
|||
Note that the "SSH Key" section in a workspace's settings is only used for mid-run operations like cloning Terraform modules. It isn't used when cloning the linked repository before a run. | |||
|
|||
## GitLab CE / GitLab EE | |||
|
|||
### "Error creating workspace - Failed to create webhook on repository: Failed to create webhook on repository: terraform/tfe: Server responded with code 422, message: Invalid url given. Request URI: <GITLAB INSTANCE HOSTNAME> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚧 This header starts with an opening "
but never closes it.
As per discussion on Slack, moving the information about "Allow requests to the local network from hooks and service" in Gitlab self hosted options into troubleshooting to better alert the user as to why they would need to do this.
In discussions, it appears that a couple of folks have missed the significance of that section of the docs due to it not being explicitly related to the 422 error seen in the TFE UI.
This PR will remove that ambiguity by specifically calling out the error message and the resolution.