Repository navigation
physical/azure: fall back to ExpiresOn when refreshing MSI tokens - #32168
Open
Sanjays2402 wants to merge 2 commits into
Open
Sanjays2402 wants to merge 2 commits into
Sanjays2402 wants to merge 2 commits into
Conversation
Fixes hashicorp#30258. The MSI token refresh callback only read the relative ExpiresIn claim to schedule the next refresh. When Azure AD returns an absolute ExpiresOn timestamp instead, ExpiresIn.Int64() fails, the callback logs an error and returns 0, so refreshes are never scheduled properly. Extract the expiry computation into tokenExpiryInSeconds, which prefers ExpiresIn and falls back to ExpiresOn.
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
1 similar comment
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30258.
The Azure storage backend's MSI token refresh callback only reads the relative
ExpiresInclaim to schedule the next refresh. When Azure AD returns an absoluteExpiresOntimestamp instead,ExpiresIn.Int64()fails, the callback logs an error and returns 0, so the refresh is never scheduled properly.The expiry computation is now a small helper,
tokenExpiryInSeconds, which prefersExpiresInand falls back toExpiresOn(converted to a relative duration), returning an error only when neither claim is present. The refresh callback itself is unchanged apart from calling it.Tests: new
TestAzureBackend_tokenExpiryInSecondscovers ExpiresIn-only, ExpiresOn-only, both present (ExpiresIn wins), and neither (error). I verified the ExpiresOn-only case fails with the old inline logic and passes with the helper. The package builds and vets clean; the remaining tests in the package need a live Azurite/docker setup, so I could not run those here.